davsclaus commented on code in PR #24498:
URL: https://github.com/apache/camel/pull/24498#discussion_r3538310293
##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelRouteTopologyAction.java:
##########
@@ -52,11 +58,17 @@
" camel cmd route-topology --json",
" camel cmd route-topology --theme=unicode",
" camel cmd route-topology --theme=dark",
- " camel cmd route-topology --theme=dark
--output=topology.png" })
+ " camel cmd route-topology --theme=dark
--output=topology.png",
+ " camel cmd route-topology hello.yaml bye.yaml" })
public class CamelRouteTopologyAction extends ActionBaseCommand {
Review Comment:
Cosmetic: `pid` is only accessed from `doCall()` on the same thread —
`volatile` is unnecessary and suggests concurrent access that doesn't exist.
Consider dropping the qualifier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
