ammachado opened a new pull request, #24508:
URL: https://github.com/apache/camel/pull/24508

   # Description
   
   Two related fixes to integration-test reliability, tracked under CAMEL-21438.
   
   **1. Fix `isRetryableContainerException` short-circuiting on 
`NoHttpResponseException`**
   
   `TestServiceUtil.isRetryableContainerException` walked the exception cause 
chain and, in the same loop pass, checked for both `NoHttpResponseException` 
and `ContainerFetchException`/`ContainerLaunchException`. Because 
testcontainers always wraps docker-java failures as the *cause* of a 
`ContainerFetchException`/`ContainerLaunchException`, the outer 
container-exception check matched first and returned `true` before the loop 
ever reached the nested `NoHttpResponseException`. As a result a dead or 
unresponsive Docker daemon was retried instead of failing fast. The fix walks 
the chain for `NoHttpResponseException` in a separate pass first, so that 
condition wins. The test is updated to wrap `NoHttpResponseException` inside a 
`ContainerLaunchException`, matching how testcontainers actually throws it.
   
   **2. Isolate `IggyConsumerOffsetIT` on a dedicated topic/stream**
   
   `IggyConsumerOffsetIT` reused the shared `TOPIC`/`STREAM`/`CONSUMER_GROUP` 
constants that other IT classes share through the same static 
`IggyService`/client, which allowed cross-test interference. It now uses 
dedicated `OFFSET_TOPIC`/`OFFSET_STREAM`/`OFFSET_CONSUMER_GROUP` names and 
asserts the exact ordered message bodies received after each batch, confirming 
the offset-based consumption behaves correctly.
   
   # Target
   
   - [x] I checked that the commit is targeting the correct branch (Camel 4 
uses the `main` branch)
   
   # Tracking
   - [x] If this is a large change, bug fix, or code improvement, I checked 
there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for 
the change (usually before you start working on it).
   
   # Apache Camel coding standards and style
   
   - [x] I checked that each commit in the pull request has a meaningful 
subject line and body.
   
   - [x] I have run `mvn clean install -DskipTests` locally from root folder 
and I have committed all auto-generated changes.
   
   # AI-assisted contributions
   
   - [x] If this PR includes AI-generated code, commits have proper 
co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR 
description identifies the AI tool used.
   
   ---
   
   _AI-assisted with Claude Code on behalf of ammachado._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to