This is an automated email from the ASF dual-hosted git repository. davsclaus pushed a commit to branch fix/CAMEL-23934 in repository https://gitbox.apache.org/repos/asf/camel.git
commit 950080544049fd293f5663e688a7fb497658bd40 Author: Claus Ibsen <[email protected]> AuthorDate: Wed Jul 8 11:37:17 2026 +0200 CAMEL-23934: Use darker green in endpoints tab Replace BRIGHT_GREEN with plain GREEN for endpoint direction indicators and chart elements for better light theme readability. Co-Authored-By: Claude Opus 4.6 <[email protected]> Signed-off-by: Claus Ibsen <[email protected]> --- .../camel/dsl/jbang/core/commands/tui/EndpointsTab.java | 15 +++++++-------- .../jbang/core/commands/tui/EndpointsTabRenderTest.java | 7 +++---- 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/EndpointsTab.java b/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/EndpointsTab.java index f2c70eae238c..2849b3340af5 100644 --- a/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/EndpointsTab.java +++ b/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/EndpointsTab.java @@ -29,7 +29,6 @@ import dev.tamboui.layout.Constraint; import dev.tamboui.layout.Layout; import dev.tamboui.layout.Rect; import dev.tamboui.markdown.MarkdownView; -import dev.tamboui.style.AnsiColor; import dev.tamboui.style.Color; import dev.tamboui.style.Style; import dev.tamboui.terminal.Frame; @@ -219,7 +218,7 @@ class EndpointsTab extends AbstractTableTab { for (EndpointInfo ep : sortedEndpoints) { String dir = ep.direction != null ? ep.direction : ""; Style dirStyle = switch (dir) { - case "in" -> Style.EMPTY.fg(Color.ansi(AnsiColor.BRIGHT_GREEN)); + case "in" -> Style.EMPTY.fg(Color.GREEN); case "out" -> Style.EMPTY.fg(Color.CYAN); default -> Theme.label(); }; @@ -466,7 +465,7 @@ class EndpointsTab extends AbstractTableTab { String inLabelStr = " ".repeat(inLabelPad) + "in" + " ".repeat(sideLen - inLabelPad - 2); String outLabelStr = " ".repeat(outLabelPad) + "out"; - Style inStyle = Style.EMPTY.fg(Color.ansi(AnsiColor.BRIGHT_GREEN)); + Style inStyle = Style.EMPTY.fg(Color.GREEN); Style outStyle = Style.EMPTY.fg(Color.CYAN); Style dimStyle = Style.EMPTY.dim(); @@ -523,7 +522,7 @@ class EndpointsTab extends AbstractTableTab { long curOut = outArr[renderPoints - 1]; Line chartTitle = Line.from( - Span.styled("▬", Style.EMPTY.fg(Color.ansi(AnsiColor.BRIGHT_GREEN))), + Span.styled("▬", Style.EMPTY.fg(Color.GREEN)), Span.raw(String.format(" in:%-4s ", MetricsCollector.formatThroughput(curIn))), Span.styled("▬", Style.EMPTY.fg(Color.CYAN)), Span.raw(String.format(" out:%-4s msg/s", MetricsCollector.formatThroughput(curOut)))); @@ -532,7 +531,7 @@ class EndpointsTab extends AbstractTableTab { frame.renderWidget(DualSparkline.builder() .topData(inArr) .bottomData(outArr) - .topStyle(Style.EMPTY.fg(Color.ansi(AnsiColor.BRIGHT_GREEN))) + .topStyle(Style.EMPTY.fg(Color.GREEN)) .bottomStyle(Style.EMPTY.fg(Color.CYAN)) .showYAxis(true) .xLabels("-" + renderPoints + "s", "-" + (renderPoints * 3 / 4) + "s", @@ -579,7 +578,7 @@ class EndpointsTab extends AbstractTableTab { String inLabelStr = " ".repeat(inLabelPad) + "in" + " ".repeat(sideLen - inLabelPad - 2); String outLabelStr = " ".repeat(outLabelPad) + "out"; - Style inStyle = Style.EMPTY.fg(Color.ansi(AnsiColor.BRIGHT_GREEN)); + Style inStyle = Style.EMPTY.fg(Color.GREEN); Style outStyle = Style.EMPTY.fg(Color.CYAN); Style dimStyle = Style.EMPTY.dim(); @@ -636,7 +635,7 @@ class EndpointsTab extends AbstractTableTab { Span.raw(" ["), Span.styled(uriLabel, Theme.label().bold()), Span.raw("] "), - Span.styled("▬", Style.EMPTY.fg(Color.ansi(AnsiColor.BRIGHT_GREEN))), + Span.styled("▬", Style.EMPTY.fg(Color.GREEN)), Span.raw(String.format(" in:%-4s ", MetricsCollector.formatThroughput(curIn))), Span.styled("▬", Style.EMPTY.fg(Color.CYAN)), Span.raw(String.format(" out:%-4s msg/s", MetricsCollector.formatThroughput(curOut)))); @@ -644,7 +643,7 @@ class EndpointsTab extends AbstractTableTab { frame.renderWidget(DualSparkline.builder() .topData(inArr) .bottomData(outArr) - .topStyle(Style.EMPTY.fg(Color.ansi(AnsiColor.BRIGHT_GREEN))) + .topStyle(Style.EMPTY.fg(Color.GREEN)) .bottomStyle(Style.EMPTY.fg(Color.CYAN)) .showYAxis(true) .xLabels("-" + renderPoints + "s", "-" + (renderPoints * 3 / 4) + "s", diff --git a/dsl/camel-jbang/camel-jbang-plugin-tui/src/test/java/org/apache/camel/dsl/jbang/core/commands/tui/EndpointsTabRenderTest.java b/dsl/camel-jbang/camel-jbang-plugin-tui/src/test/java/org/apache/camel/dsl/jbang/core/commands/tui/EndpointsTabRenderTest.java index 1542df35f61a..1bbb543e2a1d 100644 --- a/dsl/camel-jbang/camel-jbang-plugin-tui/src/test/java/org/apache/camel/dsl/jbang/core/commands/tui/EndpointsTabRenderTest.java +++ b/dsl/camel-jbang/camel-jbang-plugin-tui/src/test/java/org/apache/camel/dsl/jbang/core/commands/tui/EndpointsTabRenderTest.java @@ -22,7 +22,6 @@ import java.util.concurrent.atomic.AtomicReference; import dev.tamboui.buffer.Buffer; import dev.tamboui.layout.Rect; -import dev.tamboui.style.AnsiColor; import dev.tamboui.style.Color; import dev.tamboui.terminal.Frame; import dev.tamboui.text.Span; @@ -107,9 +106,9 @@ class EndpointsTabRenderTest { Frame frame = Frame.forTesting(buffer); tab.render(frame, area); - boolean foundBrightGreen - = TuiTestHelper.findCellWithColor(buffer, TuiIcons.KEY_RIGHT, Color.ansi(AnsiColor.BRIGHT_GREEN)); - assertTrue(foundBrightGreen, "In-direction arrow should be rendered in BRIGHT_GREEN"); + boolean foundGreen + = TuiTestHelper.findCellWithColor(buffer, TuiIcons.KEY_RIGHT, Color.GREEN); + assertTrue(foundGreen, "In-direction arrow should be rendered in GREEN"); } @Test
