davsclaus commented on PR #24511: URL: https://github.com/apache/camel/pull/24511#issuecomment-4915339315
@oscerd Thanks for the thorough review! All three points addressed in de75e634: **Lifecycle asymmetry (blocking):** Moved lock renewer cancel + renewal client close into `doStop()`, so a route stop/start cycle now properly tears down the old resources before `doStart()` creates fresh ones. Also kept defensive cleanup in `doShutdown()` for safety. Added a `stopStartCycleRecreatesLockRenewer` test that verifies resources are properly recreated across a stop/start cycle. **Documentation (suggestion):** Added upgrade guide note in `camel-4x-upgrade-guide-4_22.adoc` describing the new Camel-managed lock renewal behavior and when it activates. **Test assertion (suggestion):** Reworked `lockRenewerTracksAndRemovesExchanges` to capture the scheduled `LockRenewer` task, complete the exchange, then run the renewer and verify it does NOT attempt `renewMessageLock()` — proving the exchange was actually removed from the renewer's tracking, not just the `pendingExchanges` counter. _Claude Code on behalf of davsclaus_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
