orpiske commented on code in PR #24565:
URL: https://github.com/apache/camel/pull/24565#discussion_r3553131325
##########
core/camel-management-api/src/main/java/org/apache/camel/api/management/mbean/ManagedPerformanceCounterMBean.java:
##########
@@ -93,6 +93,15 @@ public interface ManagedPerformanceCounterMBean extends
ManagedCounterMBean {
@ManagedAttribute(description = "First Exchange Failed ExchangeId")
String getFirstExchangeFailureExchangeId();
+ @ManagedAttribute(description = "50th percentile (median) of recent
processing times [milliseconds]. Requires Extended statistics level, returns -1
otherwise.")
+ long getProcessingTimeP50();
+
+ @ManagedAttribute(description = "95th percentile of recent processing
times [milliseconds]. Requires Extended statistics level, returns -1
otherwise.")
Review Comment:
The three new methods (`getProcessingTimeP50`, `getProcessingTimeP95`,
`getProcessingTimeP99`) should include `@since 4.22` Javadoc tags per the
project's convention for new public API methods.
```suggestion
/**
* @since 4.22
*/
@ManagedAttribute(description = "50th percentile (median) of recent
processing times [milliseconds]. Requires Extended statistics level, returns -1
otherwise.")
long getProcessingTimeP50();
/**
* @since 4.22
*/
@ManagedAttribute(description = "95th percentile of recent processing
times [milliseconds]. Requires Extended statistics level, returns -1
otherwise.")
long getProcessingTimeP95();
/**
* @since 4.22
*/
@ManagedAttribute(description = "99th percentile of recent processing
times [milliseconds]. Requires Extended statistics level, returns -1
otherwise.")
long getProcessingTimeP99();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
