oscerd opened a new pull request, #1789: URL: https://github.com/apache/camel-kafka-connector/pull/1789
## Summary Resolves all 5 TODO/XXX comments in the core module identified in #1786. ## Changes 1. **sourcePartition key renamed** (`CamelSourceTask.java:220`) — Changed from `"filename"` to `"endpoint"` since this is a generic connector framework, not file-specific. The TODO is removed; the endpoint URI is the correct partition identifier for a generic framework. 2. **commitRecord cast guarded** (`CamelSourceTask.java:270`) — Added `instanceof` check before the `CamelSourceRecord` cast, replacing the XXX comment. The cast is safe (Kafka Connect passes back the same `SourceRecord` from `poll()`), confirmed in Kafka 4.x where the deprecated single-arg `commitRecord` was removed per KAFKA-18294. 3. **BigDecimal header XXX removed** (`CamelSourceTask.java:357`) — The behavior is correct: `addDecimal()` delegates encoding to the configured Kafka Connect header converter. The informational XXX was unnecessary. 4. **dumpRoutes made configurable** (`CamelKafkaConnectMain.java:226`) — Added `camel.connector.dumpRoutes` boolean property (default: `true`) to `CamelConnectorConfig`, wired through the `CamelKafkaConnectMain.Builder` and both `CamelSinkTask`/`CamelSourceTask`. Users can now disable route dumping in production. 5. **Aggregation strategy rename TODO removed** (`CamelKafkaConnectMain.java:319`) — The TODO suggested renaming `CAMEL_CONNECTOR_AGGREGATE_NAME` from `"aggregate"` to `"ckcAggregationStrategy"`, but this would break the `camel.beans.aggregate` config key. The current naming is correct; the TODO is removed. Closes #1786 ## Test plan - [x] Core module unit tests pass (`mvn verify -pl core`) - [x] Full reactor build with tests passes (`mvn clean install` — 16 min, all modules SUCCESS) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
