davsclaus commented on code in PR #24739: URL: https://github.com/apache/camel/pull/24739#discussion_r3594367528
########## test-infra/camel-test-infra-redis/src/main/resources/org/apache/camel/test/infra/redis/services/container.properties: ########## @@ -18,3 +18,4 @@ redis.container=mirror.gcr.io/redis:7.4.9-alpine redis.container.version.include=alpine redis.container.version.exclude=rc,beta redis.container.version.freeze.major=true +redis-commander.container.image=mirror.gcr.io/rediscommander/redis-commander:latest Review Comment: All other companion UI images use pinned versions (`kafka-ui:v0.7.2`, `mongo-express:1.0.2`, `pgadmin4:9`, `opensearch-dashboards:2.21.0`), but this one uses `latest`. For reproducibility, consider pinning to a specific version. ```suggestion redis-commander.container.image=mirror.gcr.io/rediscommander/redis-commander:0.8.1 ``` (Adjust the version to whatever is current — `0.8.1` is the latest stable as of this writing.) ########## test-infra/camel-test-infra-opensearch/src/main/java/org/apache/camel/test/infra/opensearch/services/OpenSearchLocalContainerInfraService.java: ########## @@ -19,24 +19,35 @@ import java.time.Duration; +import org.apache.camel.spi.annotations.InfraService; import org.apache.camel.test.infra.common.LocalPropertyResolver; import org.apache.camel.test.infra.common.services.ContainerEnvironmentUtil; import org.apache.camel.test.infra.common.services.ContainerService; import org.apache.camel.test.infra.opensearch.common.OpenSearchProperties; import org.opensearch.testcontainers.OpensearchContainer; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import org.testcontainers.Testcontainers; +import org.testcontainers.containers.GenericContainer; import org.testcontainers.containers.output.Slf4jLogConsumer; import org.testcontainers.containers.wait.strategy.LogMessageWaitStrategy; Review Comment: Minor: this class previously lacked an `@InfraService` annotation, so it wasn't discoverable via `camel infra`. Adding it here is a good fix, but it's unrelated to the UI feature. Consider a separate commit for traceability — not blocking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
