ammachado commented on code in PR #24754:
URL: https://github.com/apache/camel/pull/24754#discussion_r3600594870


##########
Jenkinsfile.deploy:
##########
@@ -17,7 +17,7 @@
 def AGENT_LABEL = env.AGENT_LABEL ?: 'ubuntu'
 def JDK_NAME = env.JDK_NAME ?: 'jdk_25_latest'
 
-def MAVEN_PARAMS = "-U -B -e -fae -V -Dnoassembly "
+def MAVEN_PARAMS = "-U -B -e -fae -V -Dnoassembly -Dcamel.exe.build=true "

Review Comment:
   No pre-provisioning needed anymore, and this is now moot for the older LTS 
branches. Two things changed since you wrote this:
   
   1. **Self-provisioning** (cb815e0): the `Setup llvm-mingw` stage runs 
`.github/actions/setup-llvm-mingw/install-llvm-mingw.sh`, which downloads a 
pinned, SHA256-verified llvm-mingw into `$HOME/.cache/llvm-mingw` when the 
cross-compilers aren't already on `PATH`. The agents don't need it 
pre-installed; the persistent cache keeps repeat runs cheap, and an agent that 
already has the compilers on `PATH` short-circuits the download. The 
compiler-existence check at the end of the stage still fails fast if 
provisioning ever goes wrong.
   
   2. **Branch scoping** (1cbf8eb, from your other comment): 
`-Dcamel.exe.build=true` moved out of the shared `MAVEN_PARAMS`, and both the 
`Setup llvm-mingw` stage and the native flags now only run on `main` and the 
future `camel-4.22.x`. `camel-4.18.x` and `camel-4.14.x` deploy their snapshots 
without touching the native build, so those pipelines can't break.
   
   So no deferral needed: old LTS is untouched, and `main`'s worst case is a 
one-time toolchain download after a cache wipe.
   
   _Claude Code on behalf of ammachado_



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to