ammachado commented on PR #24915: URL: https://github.com/apache/camel/pull/24915#issuecomment-5023799156
_Claude Code on behalf of Adriano Machado (ammachado)_ Replying to @davsclaus's review: - **`supported-lts.yml` only listing 4.22** — not an omission. This file gates which `--lts-line` values the *new* CLI packaging pipeline in this PR accepts. 4.14/4.18 were never packaged through this pipeline (it didn't exist), so there's nothing to omit; 4.22 is simply the first line eligible. - **`jreleaser-plugin-version` as a module-level property** — intentional. `jreleaser-maven-plugin` is used in exactly this one pom, and the module already declares other single-use version properties locally (`maven-version`, `plexus-*-version`, etc.) rather than centralizing. `<inherited>false</inherited>` is correctly set alongside it. - **`publish` / Homebrew dual-formula gap** — reworded both comments (`camel-package.sh`, `jreleaser.yml`, and the SDKMAN `release-notes.md` note) to drop the "Phase 5" references, which were only ever tracked in local notes, not a public tracker. The actual blocker: where each packager's artifacts get published (e.g. Homebrew to this project's own tap vs. homebrew-core) is a decision for the Apache Camel PMC. The Homebrew dual-formula gap is blocked on that same decision, not a separate follow-up — the comments now say so explicitly. - **Wildcard import** — already fixed prior to this review; replied inline. Pushed as two commits: batch-mode (`-B`) fix for the exe-build CI steps, and the comment rewording above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
