davsclaus commented on PR #25018:
URL: https://github.com/apache/camel/pull/25018#issuecomment-5045332934

   Thanks for the review @gnodet!
   
   On the minor observations:
   
   - **`:since:` field in `doTry-eip.adoc`** — Intentionally empty. All EIPs 
that predate the convention (choice, split, filter, aggregate, etc.) leave 
`:since:` empty. doTry is from the initial Camel checkin, same pattern.
   - **`renderDetail` null-guards `groupId` but not `artifactId`** — As you 
noted, both are always null together for EIPs (they come from `ArtifactModel` 
which `EipModel` doesn't extend). The `groupId` guard is sufficient.
   
   _Claude Code on behalf of davsclaus_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to