davsclaus commented on code in PR #25025:
URL: https://github.com/apache/camel/pull/25025#discussion_r3631098985
##########
components/camel-minio/src/main/java/org/apache/camel/component/minio/MinioConsumer.java:
##########
@@ -329,14 +326,13 @@ protected void processCommit(Exchange exchange) {
removeObject(srcBucketName, srcObjectName);
LOG.trace("Deleted object from bucket {} with objectName
{}...", srcBucketName, srcObjectName);
}
- } catch (MinioException | NoSuchAlgorithmException |
InvalidKeyException | IOException e) {
+ } catch (MinioException e) {
Review Comment:
The catch block was narrowed from `MinioException | NoSuchAlgorithmException
| InvalidKeyException | IOException` to just `MinioException`. If minio 9.x
still lets raw `IOException` escape (e.g. from the OkHttp layer on network
failure), this would bubble up uncaught.
Could you verify that minio 9.x wraps all I/O errors into `MinioException`?
If not, `IOException` should be retained in the catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
