davsclaus commented on code in PR #25035:
URL: https://github.com/apache/camel/pull/25035#discussion_r3636413081
##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/ExportCamelMain.java:
##########
@@ -292,6 +292,7 @@ protected Set<String> resolveDependencies(Path settings,
Path profile) throws Ex
answer.removeIf(s -> s.contains("camel-core"));
answer.removeIf(s -> s.contains("camel-main"));
answer.removeIf(s -> s.contains("camel-health"));
+ answer.removeIf(s -> s.contains("camel-micrometer-prometheus"));
Review Comment:
This `removeIf` won't catch the base-class entry because
`"camel:micrometer-prometheus".contains("camel-micrometer-prometheus")` is
**false** (colon ≠ dash).
Suggested fix: remove this line entirely and change line 305 below from:
```java
answer.add("mvn:org.apache.camel:camel-micrometer-prometheus");
```
to:
```java
answer.add("camel:micrometer-prometheus");
```
Same string the base class adds → `Set` deduplicates naturally, no
`removeIf` needed. Same change could apply to `camel-health` at line 309 →
`answer.add("camel:health")` for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
