davsclaus commented on code in PR #25101:
URL: https://github.com/apache/camel/pull/25101#discussion_r3649613964
##########
dsl/camel-jbang/camel-jbang-plugin-tui/src/test/java/org/apache/camel/dsl/jbang/core/commands/tui/TuiSettingsTest.java:
##########
@@ -71,6 +73,8 @@ void roundTripPreservesAllFields(@TempDir Path tempDir) {
assertEquals("gemini", loaded.getAiProvider());
assertEquals("gemini-3.5-flash", loaded.getAiModel());
assertEquals("https://generativelanguage.googleapis.com";,
loaded.getAiUrl());
+ assertEquals("25", loaded.getShellHistory());
Review Comment:
The new assertions added here (lines 74–75) and in
`missingFileYieldsNullFieldsWithoutThrowing` (lines 113–114) use JUnit
assertions (`assertEquals`, `assertNull`). Per project conventions, when
modifying existing test methods, touched assertions should migrate to AssertJ.
Since the sibling test files in this PR (`TuiHistoryLimitsTest`,
`TuiPromptHistoryTest`, `AiPanelPromptHistoryTest`) all use AssertJ, it would
be more consistent to use AssertJ here too:
```suggestion
assertThat(loaded.getShellHistory()).isEqualTo("25");
assertThat(loaded.getAiPromptHistory()).isEqualTo("50");
```
Not blocking — just a style consistency note.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
