atiaomar1978-hub commented on PR #25116:
URL: https://github.com/apache/camel/pull/25116#issuecomment-5085046990

   ## Review follow-up (pushed)
   
   Latest commits on `CAMEL-23969-openai-responses-api`:
   
   | Commit | Summary |
   |--------|---------|
   | `9fbbd47f3ee` | Antora: `xref:others:openai-responses.adoc`, 
`others/pages` symlink, nav + Sub-Pages (fixes PR doc validation) |
   | `6483bf0c541` | Address @davsclaus inline review |
   
   ### Changes in `6483bf0c541`
   
   - **Upgrade guide** (`camel-4x-upgrade-guide-4_22.adoc`): document 
`CamelOpenAIResponse` metadata `javaType` → 
`com.openai.models.chat.completions.ChatCompletion` (matches runtime type for 
`chat-completion` + `storeFullResponse=true`).
   - **`OpenAIResponsesSupport`**: removed unused `usageOrNull()`.
   - **`OpenAIResponsesMockTest`**: moved `collectBuiltinToolTypesInRequest` 
into the test class (no test-only helpers in production).
   - **`openai-responses.adoc`**: YAML DSL tab (aligned with other OpenAI 
sub-pages); user-facing note on deferred route-backed function tools (no JIRA 
IDs in user docs).
   
   ### Review threads
   
   Replied on all six inline threads and marked them **resolved**. Ready for 
another look when CI is green.
   
   _AI-generated comment on behalf of @atiaomar1978-hub._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to