oscerd opened a new pull request, #25147:
URL: https://github.com/apache/camel/pull/25147
## The gap
CAMEL-24137 changed the getters, setters and fluent builders in
`org.apache.camel.main.Resilience4jConfigurationProperties` from `Integer` to
`String` — verified on current `main`:
```java
public String getWaitDurationInOpenState() { ... }
public void setWaitDurationInOpenState(String waitDurationInOpenState) { ...
}
public Resilience4jConfigurationProperties withTimeoutDuration(String
timeoutDuration) { ... }
```
(plus the `slowCallDurationThreshold` and `bulkheadMaxWaitDuration` members).
That is a source-incompatible change for anyone configuring the circuit
breaker programmatically through `MainConfigurationProperties`:
```java
main.configure().resilience4j().withTimeoutDuration(1000); // no longer
compiles
```
The 4.22 upgrade guide's `camel-resilience4j - Duration options` entry
documents the **Java DSL** overloads and the **`application.properties`** keys
thoroughly, but never mentions this programmatic `camel-main` API. A user
migrating their `MainConfigurationProperties` code hits a compile error with no
corresponding guide entry.
## The change
Docs only. Adds a `*Programmatic configuration (camel-main):*` subsection to
the existing `camel-resilience4j` Duration entry, with before/after examples.
It also draws the same distinction the DSL section makes: `timeoutDuration`
and `bulkheadMaxWaitDuration` were already milliseconds, so for those two it is
a pure type change (quote the value) with no unit conversion;
`waitDurationInOpenState` and `slowCallDurationThreshold` additionally change
from seconds to milliseconds.
## Related
Last of the CAMEL-24137 follow-ups I filed from reviewing that PR. The other
two are done: CAMEL-24214 (jbang example, PR #25103) and CAMEL-24215 (JMX now
reports millis, fixed by Claus in `240b97ee8a37`).
---
_Claude Code on behalf of @oscerd_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
