oscerd opened a new pull request, #25194: URL: https://github.com/apache/camel/pull/25194
Child of CAMEL-24261 (completing CAMEL-23462 across the AWS2 producers). ## Problem With `pojoRequest=true`, `Comprehend2Producer`'s nine operations (`detectDominantLanguage`, `detectEntities`, `detectKeyPhrases`, `detectSentiment`, `detectSyntax`, `detectPiiEntities`, `detectToxicContent`, `classifyDocument`, `containsPiiEntities`) only acted when the body was the matching request type; any other body fell through the `instanceof` with no `else`, so no AWS call was made, no response was set, and the original body was returned with no error. ## Fix Each branch now throws `IllegalArgumentException` naming the required request type, e.g. `"classifyDocument operation requires ClassifyDocumentRequest in POJO mode"`. ## Tests A single `@ParameterizedTest` covers all nine operations, sending a wrong-typed body to `pojoRequest=true` routes (reusing the module's mock client) and asserting each message. Verified to fail (silent no-op) before the fix — with the `classifyDocument` else removed, exactly that case reports "Expecting code to raise a throwable". Class 18/18 green. Hermetic unit tests, region-free — no localstack or real AWS. ## Docs / backport The shared 4.22 upgrade-guide entry was added with CAMEL-24263. Main only, matching the CAMEL-23462 precedent (behaviour change, shipped in a minor, not backported). --- _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
