gnodet commented on PR #25201: URL: https://github.com/apache/camel/pull/25201#issuecomment-5110067602
@gnodet Thanks for the thorough review! I want to clarify that the review was on the **first version** of the fix (commit d702cc17 — the simple reorder), which has since been superseded by commit 4866fe7b — a **completely different approach** that addresses the root cause. Your concerns about the reorder approach were exactly right — that's why the fix was rewritten. The current version: 1. **Does NOT reorder `assertMockEndpointsSatisfied()` and `oneExchangeDone.matchesWaitTime()`** — it eliminates `oneExchangeDone` entirely 2. **Does NOT rely on implicit timeout stacking** — the race condition is structurally eliminated 3. **Writes the file BEFORE starting the route** via `Files.writeString()`, so the consumer's first poll immediately finds it 4. **Uses `isUseRouteBuilder() = false`** to defer context startup until the file is in place 5. **Uses Awaitility** for file-move assertions (as you suggested) 6. **Already drops `public`** from the class and test methods (see line 28, 36, 59 in the current code) The prior revert (PR #24945) is acknowledged in the updated PR description. _Claude Code on behalf of gnodet_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
