atiaomar1978-hub commented on PR #25204: URL: https://github.com/apache/camel/pull/25204#issuecomment-5162510296
_AI-generated comment on behalf of [atiaomar1978-hub](https://github.com/atiaomar1978-hub)_ ### Review follow-up (`d524f4db744`) Addressed @davsclaus minor items from the latest review: 1. **`isEditable()`** — simplified to `editableFile != null` (writable check already done in `loadFile()`, avoids redundant stat calls on every footer render). 2. **Esc / `c` dismiss cleanup** — non-edit dismiss now calls `hide()` instead of partially clearing state, so `saveMessage`, `deprecatedLines`, and quick-doc state are reset consistently (fixes the FolderBrowser path where `handleKeyEvent` returned before `hide()` could run). **New tests:** `escDismissClearsSaveMessageBeforeReopen`, `cKeyDismissClearsViewerState` (24 tests total in `SourceViewerEditTest`). **Local tests:** `SourceViewerEditTest` — all green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
