davsclaus commented on code in PR #25309:
URL: https://github.com/apache/camel/pull/25309#discussion_r3709675596
##########
components/camel-ai/camel-mcp-server/test-execution.md:
##########
@@ -0,0 +1,38 @@
+# camel-mcp-server test execution
Review Comment:
This file is not a standard Camel convention — other modules don't ship
`test-execution.md` files. Consider moving this content into the module's doc
page (`src/main/docs/mcp-server.adoc`) or keeping it in the PR description only.
##########
tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/MojoHelper.java:
##########
@@ -45,6 +45,7 @@ public static List<Path> getComponentPath(Path dir) {
dir.resolve("camel-langchain4j-embeddings"),
dir.resolve("camel-langchain4j-embeddingstore"),
dir.resolve("camel-langchain4j-tokenizer"),
dir.resolve("camel-langchain4j-tools"),
dir.resolve("camel-langchain4j-web-search"),
+ dir.resolve("camel-mcp-server"),
Review Comment:
Only `camel-mcp-server` is registered here, but `camel-mcp-server-api` is
also under `components/camel-ai/` and produces generated catalog artifacts
(`other.properties`, `mcp-server-api.json`). The file
`docs/components/modules/others/examples/json/mcp-server-api.json` exists but
has no nav entry. Is this intentional (the API module is a transitive dep, not
user-facing), or should either the API module be registered here too or the
orphaned doc JSON be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
