atiaomar1978-hub commented on PR #25335:
URL: https://github.com/apache/camel/pull/25335#issuecomment-5187294339
## Review summary
_AI-generated on behalf of atiaomar1978-hub_
### Automated reviews
**BugBot:** No bugs found.
**Grok review:** Addressed actionable feedback in commit 187ebc1:
1. **DEFAULT_FTPS_PORT** — Restored FTPS-specific port assignment (`2122`)
in `FtpsEmbeddedService` and `FtpsEmbeddedInfraService` without reusing the
stale instance `port` field that caused bind failures.
2. **Parallel GLOBAL property race** — Switched re-enabled FTPS ITs from
`{{ftp.server.port}}` to `service.getPort()` so parallel test classes no longer
share a GLOBAL placeholder that could resolve to another test's port.
3. **Stale port reuse branch** — Removed dead `if (port > 0)` reuse in
`FtpEmbeddedInfraService`; `tearDown()` now always resets `port = 0` for a
fresh bind.
### Local verification
All eight re-enabled FTPS integration tests pass together under Maven
parallel execution.
Ready for CI and human review when marked out of draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
