gnodet commented on code in PR #25338: URL: https://github.com/apache/camel/pull/25338#discussion_r3718762142
########## components/camel-google/camel-google-storage/src/test/java/org/apache/camel/component/google/storage/unit/ProducerBlobMetadataTest.java: ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.google.storage.unit; + +import java.io.ByteArrayInputStream; + +import com.google.cloud.storage.Blob; +import org.apache.camel.EndpointInject; +import org.apache.camel.Exchange; +import org.apache.camel.ProducerTemplate; +import org.apache.camel.builder.RouteBuilder; +import org.apache.camel.component.google.storage.GoogleCloudStorageConstants; +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotNull; + +public class ProducerBlobMetadataTest extends GoogleCloudStorageBaseTest { Review Comment: Nit: per project conventions, new test classes and methods should use package-private visibility (drop `public`), and prefer AssertJ assertions over JUnit ones. The other new test file in this PR (`GoogleCloudStorageConsumerMissingObjectTest`) already follows both conventions — it would be nice to be consistent here too. Example: ```java class ProducerBlobMetadataTest extends GoogleCloudStorageBaseTest { ``` and: ```java assertThat(blob.getContentEncoding()).isEqualTo("gzip"); ``` instead of: ```java assertEquals("gzip", blob.getContentEncoding()); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
