davsclaus commented on code in PR #25357:
URL: https://github.com/apache/camel/pull/25357#discussion_r3720541654


##########
components/camel-google/camel-google-mail/src/main/java/org/apache/camel/component/google/mail/stream/GoogleMailStreamConsumer.java:
##########
@@ -167,16 +168,22 @@ protected void processCommit(Exchange exchange, String 
unreadLabelId) {
      * Strategy when processing the exchange failed.
      */
     protected void processRollback(Exchange exchange, String unreadLabelId) {
+        if (!getConfiguration().isMarkAsRead()) {
+            // the mail was never marked as read, so there is nothing to roll 
back
+            LOG.warn("Exchange failed: {}", exchange);

Review Comment:
   why are we WARN logging here when this method is about marking the mail as 
un-read, and this is an early exit to not do that, so I would assume this LOG 
should be removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to