atiaomar1978-hub commented on PR #25368:
URL: https://github.com/apache/camel/pull/25368#issuecomment-5200072991
## Implementation summary
This PR adds optional `argSchema` to `camel-ai-tool` for declaring nested
tool parameters as raw JSON Schema (inline or via
`classpath:`/`file:`/`resource:` references), mutually exclusive with flat
`parameter.*` options.
### Highlights
- Executor allowlist/required derived from schema top-level
`properties`/`required` (CAMEL-24241 follow-up)
- Startup validation: root object, non-empty properties, valid `required`
array, required names must exist in properties
- LangChain4j adapter converts nested schemas with metadata stripping
fallback
- Catalog metadata regenerated; AssertJ tests added
### Review feedback addressed
- JSON `null` / malformed schema NPEs fixed
- Required-parameter check uses filtered `argsCopy` after allowlist filtering
- Documentation clarifies top-level allowlist behavior
### Testing
```
./mvnw -B -pl
components/camel-ai/camel-ai-tool,components/camel-ai/camel-langchain4j-agent
-am test \
-Dtest=AiToolParameterHelperTest,AiToolExecutorTest,AiToolEndpointLifecycleTest,AiToolSpecToLangChain4jTest
```
All targeted tests pass.
_AI-generated summary on behalf of atiaomar1978-hub via Cursor Cloud Agent._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
