atiaomar1978-hub commented on PR #25398: URL: https://github.com/apache/camel/pull/25398#issuecomment-5209902488
## Automated review summary _AI-generated on behalf of atiaomar1978-hub_ Bugbot and Grok reviews were run on this PR. Key findings and disposition: ### Addressed in latest commit | Finding | Fix | |---------|-----| | Catalog/Endpoint DSL missing `outputSchema`/`outputParameters` | Regenerated `catalog/camel-catalog` and `dsl/camel-endpointdsl` | | Null/blank body succeeds without `structuredContent` when output schema declared | `parseStructuredOutput` now throws; executor returns `ExecutionError` | | Upgrade guide understates SPI changes | Expanded with `McpToolCallResult`, `McpServerTool`, `AiToolSpec` notes | ### Acknowledged / deferred | Finding | Rationale | |---------|-----------| | No JSON Schema instance validation against `outputSchema` | Advertise schema + parse JSON; clients validate (documented). Full validation is a follow-up if PMC wants it. | | LangChain4j/Spring AI typed tool results | Explicitly out of scope for this PR; JIRA follow-up | | `mcp-server.adoc` cross-link | Can add in a small doc follow-up | | Schema validation on `outputSchema` shape | Intentionally permissive (any JSON Schema type), unlike input `argSchema` | CI checks pending on the updated branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
