atiaomar1978-hub commented on PR #25409:
URL: https://github.com/apache/camel/pull/25409#issuecomment-5228884957
## Test coverage follow-up
_AI-generated on behalf of @atiaomar1978-hub_
Checked automated test coverage for this PR — **no test files are added or
modified**. Verification is manual only (as noted in the PR description). That
gap is worth addressing given the **api-component readme regression** this PR
fixes.
### Current state
| Area | Coverage |
|---|---|
| **This PR** | 0 test file changes across 26 files |
| **Archetype ITs** | Exist under `src/test/resources/projects-disabled/` in
all 6 archetypes — **`projects-disabled` means they do not run** in CI (Maven
archetype plugin expects `projects/`) |
| **JBang precedent (CAMEL-23702 / #24063)** |
`ExportTest.shouldGenerateContent` and `shouldGenerateJavaContent` **assert
`AGENTS.md` and `readme.md` exist** after export — automated guard for the same
feature on the JBang side |
| **Archetypes module** | `archetype.test.skip=true` under `skipTests`,
`fastinstall`, and `release` profiles |
### What manual verification covers (per PR)
✅ `mvn archetype:generate` for all six archetypes
✅ `README.md` + `AGENTS.md` present at project root
✅ No unresolved `${...}` / `__x__` tokens
✅ URL checks
### What is **not** guarded by CI
- `README.md` / `AGENTS.md` emitted at all (regression like api-component
readme in wrong fileSet)
- api-component readme at **project root** vs under `*-component/` module
- Doc content accuracy (packaged paths, `@Dataformat`, etc.)
- Upgrade guide index linkage
### Suggestions (pick one — ordered by ROI)
**Option A — Minimal archetype IT (recommended)**
Rename `projects-disabled` → `projects` for at least **`build-it`** goal on
each archetype (or start with api-component + java). Extend the
generated-project assertion to verify:
```
README.md exists at project root
AGENTS.md exists at project root
no ReadMe.txt
(api-component) README.md NOT only under *-component/
```
This would have caught the pre-4.22 api-component bug automatically.
**Option B — Shared unit test in `archetypes/` parent**
One parameterized JUnit test (similar spirit to `ExportTest`) that runs
`archetype:generate` into a temp dir for each archetype artifactId and asserts
the two markdown files exist. Keeps ITs disabled but adds a fast smoke test in
default CI.
**Option C — Follow-up JIRA**
If enabling ITs is blocked on ARCHETYPE-574 (noted in
`archetype.properties`), open a follow-up to re-enable once fixed — but Option
B could land independently.
### Verdict on test coverage
**Insufficient for merge without follow-up** — acceptable for docs-only
archetype change *if* manual verification is repeated each release, but **not
ideal** for a change whose main bug was silent fileSet misconfiguration.
Recommend **Option A or B in this PR or an immediate follow-up** before 4.23.
Happy to re-review if tests are added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
