atiaomar1978-hub commented on PR #25433: URL: https://github.com/apache/camel/pull/25433#issuecomment-5268993084
## Review feedback addressed (@davsclaus) Thanks for the follow-up review. The latest commit (`eb936edc`) addresses all remaining items: | # | Severity | Issue | Fix | |---|----------|-------|-----| | 1 | **Blocking** | BOM hardcoded `4.22.0-SNAPSHOT` | Updated alibaba modules to `4.23.0-SNAPSHOT` in `bom/camel-bom/pom.xml` | | 2 | **Important** | OSS `accessKey`/`secretKey` missing `secret = true` | Added `secret = true`, `security = \"secret\"`, `label = \"security\"` on OSS and MNS credentials | | 3 | **Important** | OSS producer read runtime overrides from properties | `OSSUtils.createClientConfigurations()` resolves headers first, then properties, then endpoint | | 4 | **Important** | OSS producer serialized results to Gson JSON | Producer returns structured `Map`/`List<Map>`; Gson dependency removed | | 5 | **Moderate** | Inconsistent MNS credential annotations | MNS endpoint credentials now match OSS (`secret`, `security`, `label`) | | 6 | **Moderate** | `operation` as `@UriPath` | URI is now `alibaba-oss:bucketName?operation=...`; bucket in path, operation as query param | | 7 | **Minor** | Duplicate receipt-handle constants | Removed `RECEIPT_HANDLE`, `MESSAGE_ID`, `MESSAGE_BODY_MD5` from `MNSProperties`; use `MNSHeaders` | Docs, tests, component metadata, and catalog JSON updated accordingly. ### Tests All alibaba module unit tests passing locally: ```bash ./mvnw -pl components/camel-alibaba/camel-alibaba-common,components/camel-alibaba/camel-alibaba-oss,components/camel-alibaba/camel-alibaba-mns -am test -Dtest='org.apache.camel.component.alibaba.**' -Dsurefire.failIfNoSpecifiedTests=false ``` Ready for re-review once CI is green. _AI-generated comment on behalf of atiaomar1978-hub_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
