Copilot commented on code in PR #1729:
URL: https://github.com/apache/camel-website/pull/1729#discussion_r3786036017
##########
antora-ui-camel/package.json:
##########
@@ -9,7 +9,7 @@
"url": "https://github.com/apache/camel-website.git";
},
"engines": {
- "node": ">= 8.0.0"
+ "node": ">= 18.0.0"
},
Review Comment:
`antora-ui-camel` now declares `engines.node: >= 18.0.0`, but the
repository’s `.nvmrc` still pins Node 14. Developers using `nvm use` will end
up on an unsupported Node version for this workspace, which can cause
install/build failures. Please update `.nvmrc` (and any other Node-version
docs/tooling) to match the new minimum, or document why the workspace requires
a higher Node version than the repo default.
##########
antora-ui-camel/gulp.d/tasks/build-preview-pages.js:
##########
@@ -25,13 +25,13 @@ module.exports = (src, previewSrc, previewDest, sink = ()
=> map()) => (done) =>
Promise.all([
loadSampleUiModel(previewSrc),
toPromise(
- merge(
+ ordered([
Review Comment:
`buildPreviewPages` currently returns a Promise chain whose final `.then()`
returns a vinyl-fs stream. Gulp/undertaker will consider the task complete when
the Promise resolves (immediately), and will not wait for the stream to finish
writing files. This can lead to partially-written preview output and race
conditions with downstream tasks/watchers. Restructure this task to return the
stream directly, or return a Promise that settles on the stream's completion
(e.g., wrap the stream with `stream/promises` `pipeline()`/`finished()` or a
manual `end`/`error` listener).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
