ammachado opened a new pull request, #25509: URL: https://github.com/apache/camel/pull/25509
# Description `formula.rb.tpl` (the Homebrew formula template rendered by JReleaser for `camel-launcher`) set both a `url` and an explicit `version` field. Homebrew's `brew audit --strict` flags an explicit `version` as redundant whenever it can already be inferred by scanning the `url` (which it can here, since the URL embeds the Maven coordinate version). Any real submission of the generated formula to `homebrew-core` would fail this audit gate. Fix: drop the redundant `version` line from the template. `camel-validate.sh`'s Homebrew validation step previously read the *expected* post-install version back out of that same `version` field (needed because in CI's test-mode staging the formula's real POM version, e.g. a `-SNAPSHOT`, differs from the release-manager-facing resolved version). Removing the field regressed that check, so it now reads the expected version out of the formula's `url` instead, captured before the test-mode step rewrites that `url` to a local `file://` path for the offline install. Found and fixed while running `camel-package.sh prepare` + `camel-validate.sh all` for the already-released `camel-4.22.0` version to verify the launcher's JReleaser release procedure end-to-end. Verified locally: re-ran `camel-package.sh prepare --channel stable` + `camel-validate.sh all` in the project's own `CAMEL_PACKAGE_TEST_MODE` (the same mechanism `.github/workflows/package-native-validation.yml` uses in CI) — `brew audit --strict` now reports no offenses, and the post-install version check passes. # Target - [x] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch) # Tracking - [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). # Apache Camel coding standards and style - [x] I checked that each commit in the pull request has a meaningful subject line and body. - [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes. This change only touches a shell script and a Mustache template (no Java sources), so the Maven formatter/impsort step has nothing to reformat; the pre-push hook's `mvn formatter:format impsort:sort` ran clean with no changes. A full root build was not run given the change's scope. # AI-assisted contributions - [x] If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR description identifies the AI tool used. _Claude Code (Sonnet 5) on behalf of Adriano Machado (@ammachado)_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
