atiaomar1978-hub commented on PR #24485: URL: https://github.com/apache/camel/pull/24485#issuecomment-5305352780
**Question: why was this PR closed, and is there a replacement?** _AI-generated comment on behalf of Omar Atie_ PR #24485 was parked after @zbendhiba's review (integration tests needed; wait for `camel-ai-tool`), and the branch was closed on Aug 13. However, the **CAMEL-23928 changes were already merged into `main` via PR #24492** (Jul 7) — `AgentConfiguration` tool-calling options and `aiServicesCustomizer` are on `main` today. **`camel-ai-tool` does not replace this PR** — it replaces the old tool execution model (`langchain4j-tools` / `spring-ai-tools`) with `ai-tool:` + `AiToolRegistry` + `AiToolExecutor`. The #24485 options configure the LangChain4j **agent** (`AiServices` builder); `camel-ai-tool` defines and runs **route tools**. They work together. Gaps identified in review were addressed separately: - **CAMEL-23944** — route tool errors now propagate so `ToolExecutionErrorHandler` / `compensateOnToolErrors` can fire - **CAMEL-23929** (open) — `@UriParam` exposure for scalar options like `maxToolCallingRoundTrips` Remaining limitations vs the original #24485 intent: - `compensateOnToolErrors` still only applies to annotated `@Tool` methods, not Camel route tools - `toolArgumentsErrorHandler` may not fire for route-tool argument validation (errors returned as strings) Closing #24485 makes sense as housekeeping; the functionality lives on `main` via #24492 + follow-ups. Anyone needing URI-level config should track **CAMEL-23929**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
