gnodet commented on PR #25510:
URL: https://github.com/apache/camel/pull/25510#issuecomment-5305891514
_Claude Code on behalf of gnodet_
Thank you for the thorough review!
Addressing your nits:
1. **Test plan checkboxes** — Updated and all checked ✓
2. **Dedicated unit test** — Added `PQCKeyStoreJdk25KeyConversionTest` with
`@EnabledForJreRange(min = JRE.JAVA_25)` in commit 790f176. It exercises the
ML-DSA sign+verify flow via JKS KeyStore and is automatically skipped on Java
<25 where the conversion is a no-op. All 211 tests pass (210 executed + 1
skipped on Java 21).
3. **BC detection** — Acknowledged, the `startsWith("org.bouncycastle.")`
check is intentionally pragmatic; worst case, a non-BC key falls through to
re-encoding which is safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
