mustafaAlmonayer commented on PR #25529: URL: https://github.com/apache/camel/pull/25529#issuecomment-5326654854
First of all, thank you all for this magnificent framework — it has been a pleasure to build on, and I'm grateful for the chance to give something back. I owe you a couple of apologies up front, and I'd rather be transparent about them than have them surface in review. All of the test cases here, including the integration tests, were carried out manually by running the application against a real three-node ZooKeeper ensemble. I have very limited experience writing automated tests in Apache Camel, so I wasn't able to translate those scenarios into proper automated coverage. I'm sorry about that — I know it's a serious gap, especially for a change in this area, and I would very much welcome any pointers on the right harness and patterns to use. The reason I moved quickly is the nature of the defect itself: it undermines the core purpose of the ZooKeeper cluster service by allowing a split-brain condition in which more than one instance holds leadership and stays active at the same time. I also tried to open a JIRA issue before raising this PR, but my ASF account request is still awaiting confirmation, and I didn't want to sit on the fix while waiting. Apologies for not following the usual process. If someone else is able to approve the request — or file the ticket on my behalf — I'll link it here and update the PR title right away. Thank you again for taking the time to look at this, and for all the work that goes into maintaining Camel. I'm glad to make any changes you'd like. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
