JiriOndrusek commented on PR #9018: URL: https://github.com/apache/camel-quarkus/pull/9018#issuecomment-5330191594
Thanks for the thorough review. Everything is addressed in 2541fc3a5b — kept deliberately as a separate commit so the delta stays reviewable against the original; I'll squash it into the main commit on merge if you prefer a single-commit history. The two settle-before-merge items: - `skip-testcontainers-tests` is declared. I excluded only the two container-backed test classes instead of the module-wide `skipTests`, so the file and endpoint tests still run on the alternative-platform job — a pom comment explains the deviation from the convention. - The config namespace is now `quarkus.camel.langchain4j.ingest.*`, aligned with #9013 and the extension name; route ids follow suit. The inline findings are applied — short confirmation on each thread — with one decline: reusing the shared aws2 test support. `Aws2TestResource` is final and module-global by design and does not survive `restrictToAnnotatedClass`, which this module needs to keep its Docker-free tests running on Windows; details on that thread. On the scope question: agreed it deserves an explicit record — I'll follow up on #9015 with the plan. Short version: the engine core is deliberately Quarkus-free, the intent is to propose a `camel-langchain4j-ingest` component upstream and have this extension delegate to it while keeping the declarative surface (properties, `@Ingest`, build-time validation) here; the metadata keys will be parameterized so upstream can use runtime-neutral names. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
