atiaomar1978-hub commented on PR #25565:
URL: https://github.com/apache/camel/pull/25565#issuecomment-5373698975
## Review (Bugbot + Grok + manual)
_AI-generated review._
**Verdict:** Looks good to merge with minor follow-ups. CI is green;
implementation matches existing `CamelAwsS3CannedAcl` patterns.
### Bugbot
No bugs found in grant header wiring for `PutObject` and
`CreateMultipartUpload`.
### Security
No medium-or-higher findings. Grant headers use the `Camel*` namespace and
follow the same trust model as `CamelAwsS3CannedAcl`: route authors are
trusted, AWS IAM + bucket policy enforce authorization. Routes bridging
untrusted senders should still use `removeHeaders("Camel*")` at the trust
boundary.
### Test coverage gaps
1. **Multipart `CreateMultipartUpload` not tested** —
`AWS2S3ProducerAclGrantTest` only captures `PutObjectRequest`. The PR
description mentions multipart, but there is no test that forces a payload ≥
`partSize` and asserts grants on `CreateMultipartUploadRequest`.
2. **`AWS2S3StreamUploadProducer` not updated** — streaming upload supports
`CANNED_ACL` but not the new grant headers. Functional inconsistency; consider
a follow-up or a note in the PR.
### Documentation
`aws2-s3-producer-operations.adoc` documents `CamelAwsS3CannedAcl` but not
the four new grant headers. Worth adding examples there.
### Minor (non-blocking)
- Grant header block is duplicated in `doPutObject()` and
`processMultiPart()` — a small helper would reduce drift risk.
- A one-line comment on grant + `acl()` coexistence (AWS semantics) would
help future readers.
Nice work on closing the AWS SDK grant-header gap for put/multipart upload
paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
