davsclaus commented on code in PR #25508:
URL: https://github.com/apache/camel/pull/25508#discussion_r3842723252
##########
components/camel-paho/src/main/java/org/apache/camel/component/paho/PahoConsumer.java:
##########
@@ -57,81 +57,128 @@ public void setClient(MqttClient client) {
protected void doStart() throws Exception {
Review Comment:
This is a substantive behavior fix (client/thread leak on failed startup),
but I don't see a JIRA issue referenced anywhere in the PR or commits. Per this
project's convention, bug-fix commits should follow `CAMEL-XXXX: <description>`
— could you file a ticket (https://issues.apache.org/jira/browse/CAMEL) and
reference it in the PR title/commits? That's also needed for `fixVersions`
tracking at merge time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
