oscerd opened a new pull request, #1813:
URL: https://github.com/apache/camel-kafka-connector/pull/1813
`main` is currently red and every open pull request inherits the failure.
## What broke
`225a5b7ab3` (#1796) appended its new imports instead of sorting them into
the existing blocks:
```java
import org.apache.camel.kafkaconnector.utils.CamelKafkaConnectMain;
import org.apache.camel.ProducerTemplate; // <- after
org.apache.camel.kafkaconnector.*
import org.apache.camel.component.syslog.SyslogMessage;
...
import static org.junit.jupiter.api.Assertions.assertInstanceOf; // <-
before assertFalse
import static org.junit.jupiter.api.Assertions.assertFalse;
```
CI runs checkstyle with `-Psourcecheck -Dcheckstyle.failOnViolation=true`,
which rejects this:
```
DataFormatTest.java:26: Wrong order for 'org.apache.camel.ProducerTemplate'
import. [ImportOrder]
```
The `Camel Kafka Connect CI` run on `225a5b7a` failed, and because pull
request CI builds the merge
commit against `main`, unrelated PRs fail on this same violation — e.g.
#1810 and #1811 report it
against a file neither of them touches.
A plain `mvn test` does not run checkstyle, which is presumably how it got
through locally.
## Fix
Sort the imports. No behavioural change.
## Verification
- `core`: full test suite passes.
- `./mvnw -Psourcecheck -Dcheckstyle.failOnViolation=true -DskipTests -pl
:camel-kafka-connector-model -pl :camel-kafka-connector-generator-maven-plugin
-pl :camel-kafka-connector clean install`
— the exact step CI fails on — BUILD SUCCESS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
