mayurbm commented on code in PR #25555: URL: https://github.com/apache/camel/pull/25555#discussion_r3843785837
########## core/camel-xml-jaxp/src/main/java/org/apache/camel/converter/jaxp/XmlConverter.java: ########## Review Comment: The `StreamCache` overload previously delegated to `toDOMDocument(InputStream, Exchange)`, which does not have the `SAXParseException` catch. To ensure the same friendly `TypeConversionException` wrapping applies to `StreamCache` payloads as well, I routed it through `toDOMDocument(byte[], Exchange)` where the catch lives. If you prefer to keep streaming, I can instead move the `try/catch SAXParseException` into `toDOMDocument(InputStream, Exchange)` and have both overloads delegate there — that avoids the `byte[]` materialization for the `StreamCache` path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
