mayurbm commented on PR #25553: URL: https://github.com/apache/camel/pull/25553#issuecomment-5398344274
Hi @davsclaus, thank you for the review! Addressed both comments: **Comment 1 — catch message wording (`MailConsumer.java` line 534):** You are correct — `copyOrMoveMessageIfRequired()` is also inside the same `try` block and can throw `MessageRemovedException` per its javadoc contract, so `"(no flag update possible)"` was inaccurate. Updated the message to `"(message state could not be updated)"` which holds regardless of which operation in `processCommit()` triggers the expunge. Test assertion updated to match. **Comment 2 — test style (reflection into `folder` field):** Acknowledged. Simulating a real expunge-race through `Mailbox`/GreenMail deterministically would be considerably harder to engineer, so the reflection-based unit test approach is kept for now. Happy to add a package-private test seam to `MailConsumer` if that is preferred. Local validation: - `mvn formatter:format impsort:sort` — no changes needed - `Tests run: 2, Failures: 0, Errors: 0, Skipped: 0` Both review threads resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
