oscerd commented on PR #2978:
URL: https://github.com/apache/camel-kamelets/pull/2978#issuecomment-5408067099
Narrowed further: `exec-sink` is dropped too, so this PR is now a **single
file** — `aws-ec2-sink`.
Reasoning is the sceptical note from the description: `camel-exec` honours
none of its documented `CamelExecCommand*` headers on 4.22.0 (#2980), so
stripping them was a no-op that would only start doing anything if that is
fixed upstream. Not worth carrying in the catalog until then — it can be
revisited alongside #2980.
What remains stands on its own and takes effect today: `aws-ec2-sink` pins
`operation: describeInstancesStatus`, a read-only call, and a
`CamelAwsEC2Operation` header could turn that into any other EC2 operation the
component supports.
```yaml
- removeHeaders:
pattern: "CamelAwsEC2*"
excludePattern: "CamelAwsEC2(NextToken|MaxResults)"
- choice: # instanceIds / ce-instanceids ->
CamelAwsEC2InstancesIds
```
@davsclaus your pattern suggestion is what this file uses — strip up-front,
let the Kamelet re-apply its own contract afterwards, no exception list needed
and future `CamelAwsEC2*` keys covered. The one `excludePattern` keeps
`NextToken` / `MaxResults`, the pagination headers the pinned operation
actually reads.
Title and description updated. Since the scope has moved twice since your
approval, a fresh look would be welcome before this goes in.
---
_Claude Code on behalf of Andrea Cosentino_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
