Croway commented on PR #125: URL: https://github.com/apache/camel-upgrade-recipes/pull/125#issuecomment-5409218710
Thanks Jiří — all three points addressed in e047318, replies inline on the two threads. Summary: | Point | Resolution | |---|---| | No Camel-file precondition on the XML recipe | `RecipesUtil.camelXmlDslPrecondition()` added and `RenameHeaderInXmlDsl` gated, with a non-Camel-XML negative test | | Ungated starter swap in multi-module builds | Gated on the module declaring a Spring Boot dependency, verified on a two-module scratch build | | `RemoveDuplicateDependencies` dedupes the whole pom | Dropped — it was not needed, `ChangeDependencyGroupIdAndArtifactId` does not duplicate an already-declared artifact | | `release_notes.adoc` still lists the ChatCompletion recipe | Row now reads `❌ None` and explains why no migration is required | On the release notes: I first added a `➖ Not needed` marker, then changed it to `❌ None` since the table only uses Full / Partial / None and the intro text names exactly those three. Chasing your first point also turned up a pre-existing defect worth flagging: `XmlDsl46Recipe` matches `bean/property` in any XML, so Spring bean files were being rewritten into `<bean><properties><property/></properties></bean>` — silently invalid Spring configuration. I gated that recipe too and added a negative test, but it is not a 4.22 issue, so I am happy to split it out if you prefer this PR stays scoped. More broadly, only 2 of the 13 `AbstractCamelXmlVisitor` classes are gated even after this change; I would suggest a follow-up ticket for the other 11 rather than widening this PR further. Verification: `mvn clean install` on JDK 17 (matching CI) — 828 core and 12 Spring Boot tests, no failures. Re-applied to all four scratch projects; the Camel 4.14 project still compiles cleanly against 4.22.0 after the full chain. _Claude Code on behalf of Federico Mariani_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
