JiriOndrusek commented on code in PR #127:
URL:
https://github.com/apache/camel-upgrade-recipes/pull/127#discussion_r3852910149
##########
camel-upgrade-recipes/src/main/java/org/apache/camel/upgrade/camel418_3/RenameHeaderPrefixInXmlDsl.java:
##########
@@ -69,7 +71,8 @@ public String getDescription() {
@Override
public TreeVisitor<?, ExecutionContext> getVisitor() {
- return new XmlHeaderPrefixVisitor(oldPrefix, newPrefix);
+ return Preconditions.check(RecipesUtil.camelXmlDslPrecondition(),
Review Comment:
`isCamelXmlDsl` rejects any root declaring the Spring beans namespace before
checking anything else — but `<beans><camelContext
xmlns="http://camel.apache.org/schema/spring";>` is the classic Camel XML
layout, and `declaresNamespace` only reads root attributes. All gated recipes
now silently skip Spring-XML Camel files, and no positive `<beans>`-wrapped
test exists to catch it. Please accept documents with a camel
namespace/`camelContext` on a descendant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
