This is an automated email from the ASF dual-hosted git repository.
jbonofre pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel-karaf.git
The following commit(s) were added to refs/heads/main by this push:
new 414562ee1 fix(#713): add missing transitive dependencies to camel-tika
feature (#716)
414562ee1 is described below
commit 414562ee1641ecfaa464789bd62f45be800b7f99
Author: JB Onofré <[email protected]>
AuthorDate: Wed Aug 26 08:07:49 2026 +0200
fix(#713): add missing transitive dependencies to camel-tika feature (#716)
* fix(#713): add missing transitive dependencies to camel-tika feature
The camel-tika feature was missing the transitive runtime dependencies of
tika-parser-html-module (jsoup, commons-codec) and tika-parser-text-module
(commons-csv, juniversalchardet). Without them, tika operations such as
tika:detect/tika:parse fail at runtime with NoClassDefFoundError (e.g.
org.apache.tika.parser.txt.UniversalEncodingListener needs
org.mozilla.universalchardet.*).
jsoup, commons-codec and commons-csv are already proper OSGi bundles and are
added as plain mvn: bundles. com.github.albfernandez:juniversalchardet 2.5.0
ships without OSGi metadata, so it is installed via wrap:.
The stale, unused juniversalchardet-version property (1.0.3, the old
com.googlecode groupId) is bumped to 2.5.0 to match the version Tika 3.2.3
pulls in.
Adds a Pax Exam integration test (tests/features/camel-tika) that parses a
plain-text body through tika:parse, exercising the text parser and its
juniversalchardet dependency at runtime.
* test(#713): scope camel-tika itest to feature resolution
The camel-tika itest asserted that tika:parse extracts text, but in Karaf
tika:parse returns empty content: Tika's AutoDetectParser discovers parsers
through the JDK ServiceLoader, which does not cross OSGi bundle boundaries.
Wiring Tika's parser SPI for OSGi is out of scope for issue #713, whose fix
is
the missing juniversalchardet bundle so tika-parser-text-module resolves.
Scope the test to what #713 fixes: the feature installs and the tika:parse
route processes one exchange end-to-end (expectedMessageCount(1)). Before
the
fix the tika-parser-text-module bundle could not wire (missing
org.mozilla.universalchardet), so the route never started and no message
reached the mock.
---
features/src/main/feature/camel-features.xml | 4 ++
pom.xml | 2 +-
tests/features/camel-tika/pom.xml | 48 ++++++++++++++++++
.../karaf/camel/test/CamelTikaRouteSupplier.java | 48 ++++++++++++++++++
.../apache/karaf/camel/itest/CamelTikaITest.java | 57 ++++++++++++++++++++++
tests/features/pom.xml | 1 +
6 files changed, 159 insertions(+), 1 deletion(-)
diff --git a/features/src/main/feature/camel-features.xml
b/features/src/main/feature/camel-features.xml
index e3389ec6e..dddf5bdb4 100644
--- a/features/src/main/feature/camel-features.xml
+++ b/features/src/main/feature/camel-features.xml
@@ -3473,6 +3473,10 @@ Chain 2:
<bundle
dependency='true'>mvn:org.apache.tika/tika-parser-html-module/${tika-version}</bundle>
<bundle
dependency='true'>mvn:org.apache.tika/tika-parser-text-module/${tika-version}</bundle>
<bundle
dependency='true'>mvn:commons-io/commons-io/${commons-io-version}</bundle>
+ <bundle dependency='true'>mvn:org.jsoup/jsoup/${jsoup-version}</bundle>
+ <bundle
dependency='true'>mvn:commons-codec/commons-codec/${commons-codec-version}</bundle>
+ <bundle
dependency='true'>mvn:org.apache.commons/commons-csv/${commons-csv-version}</bundle>
+ <bundle
dependency='true'>wrap:mvn:com.github.albfernandez/juniversalchardet/${juniversalchardet-version}</bundle>
<bundle>mvn:org.apache.camel.karaf/camel-tika/${project.version}</bundle>
</feature>
<feature name='camel-torchserve' version='${project.version}'
start-level='50'>
diff --git a/pom.xml b/pom.xml
index d0e8b8d8c..d736beb4f 100644
--- a/pom.xml
+++ b/pom.xml
@@ -373,7 +373,7 @@
<junit-jupiter-version>5.13.4</junit-jupiter-version>
<junit6-jupiter-version>6.0.1</junit6-jupiter-version>
<junit-pioneer-version>2.3.0</junit-pioneer-version>
- <juniversalchardet-version>1.0.3</juniversalchardet-version>
+ <juniversalchardet-version>2.5.0</juniversalchardet-version>
<jxmpp-version>1.1.0</jxmpp-version>
<jython-version>2.7.4</jython-version>
<jzlib-version>1.1.3</jzlib-version>
diff --git a/tests/features/camel-tika/pom.xml
b/tests/features/camel-tika/pom.xml
new file mode 100644
index 000000000..c824193b4
--- /dev/null
+++ b/tests/features/camel-tika/pom.xml
@@ -0,0 +1,48 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.camel.karaf</groupId>
+ <artifactId>camel-karaf-features-test</artifactId>
+ <version>4.18.2-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>camel-tika-test</artifactId>
+ <name>Apache Camel :: Karaf :: Tests :: Features :: Tika</name>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-core</artifactId>
+ <version>${camel-version}</version>
+ <scope>provided</scope>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <resources>
+ <resource>
+ <directory>../../../src/main/resources</directory>
+ <filtering>false</filtering>
+ </resource>
+ </resources>
+ </build>
+</project>
diff --git
a/tests/features/camel-tika/src/main/java/org/apache/karaf/camel/test/CamelTikaRouteSupplier.java
b/tests/features/camel-tika/src/main/java/org/apache/karaf/camel/test/CamelTikaRouteSupplier.java
new file mode 100644
index 000000000..806179cd8
--- /dev/null
+++
b/tests/features/camel-tika/src/main/java/org/apache/karaf/camel/test/CamelTikaRouteSupplier.java
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.karaf.camel.test;
+
+import org.apache.camel.builder.RouteBuilder;
+import org.apache.camel.model.RouteDefinition;
+import
org.apache.karaf.camel.itests.AbstractCamelSingleFeatureResultMockBasedRouteSupplier;
+import org.apache.karaf.camel.itests.CamelRouteSupplier;
+import org.osgi.service.component.annotations.Component;
+
+@Component(
+ name = "karaf-camel-tika-test",
+ immediate = true,
+ service = CamelRouteSupplier.class
+)
+public class CamelTikaRouteSupplier extends
AbstractCamelSingleFeatureResultMockBasedRouteSupplier {
+
+ @Override
+ protected boolean consumerEnabled() {
+ return false;
+ }
+
+ @Override
+ protected void configureProducer(RouteBuilder builder, RouteDefinition
producerRoute) {
+ // Route the body through tika:parse. The value of this route is that
it forces the
+ // camel-tika feature (including tika-parser-text-module and its
juniversalchardet
+ // dependency, which were missing before issue #713) to resolve and
run; a message
+ // reaching the mock proves the feature is now wired correctly.
+ producerRoute.log("Will parse: ${body}")
+ .to("tika:parse?tikaParseOutputFormat=text")
+ .convertBodyTo(String.class)
+ .log("Parsed: ${body}")
+ .toF("mock:%s", getResultMockName());
+ }
+}
diff --git
a/tests/features/camel-tika/src/test/java/org/apache/karaf/camel/itest/CamelTikaITest.java
b/tests/features/camel-tika/src/test/java/org/apache/karaf/camel/itest/CamelTikaITest.java
new file mode 100644
index 000000000..5d0df9833
--- /dev/null
+++
b/tests/features/camel-tika/src/test/java/org/apache/karaf/camel/itest/CamelTikaITest.java
@@ -0,0 +1,57 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.karaf.camel.itest;
+
+import org.apache.camel.component.mock.MockEndpoint;
+import
org.apache.karaf.camel.itests.AbstractCamelSingleFeatureResultMockBasedRouteITest;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.ops4j.pax.exam.junit.PaxExam;
+import org.ops4j.pax.exam.spi.reactors.ExamReactorStrategy;
+import org.ops4j.pax.exam.spi.reactors.PerClass;
+
+/**
+ * Verifies the {@code camel-tika} feature installs and a {@code tika:parse}
route runs end-to-end
+ * (issue #713). The point of the test is that the feature now resolves:
before the fix the
+ * {@code tika-parser-text-module} bundle failed to wire because its {@code
juniversalchardet}
+ * dependency (package {@code org.mozilla.universalchardet}) was missing from
the feature, so the
+ * route could never be created and no message would reach the mock.
+ * <p>
+ * The test deliberately does not assert on the extracted text: Tika's {@code
AutoDetectParser}
+ * discovers parsers through the JDK {@link java.util.ServiceLoader}, which
does not cross OSGi
+ * bundle boundaries, so {@code tika:parse} yields empty content in Karaf.
Wiring Tika's parser SPI
+ * for OSGi is a separate concern beyond the scope of issue #713.
+ */
+@RunWith(PaxExam.class)
+@ExamReactorStrategy(PerClass.class)
+public class CamelTikaITest extends
AbstractCamelSingleFeatureResultMockBasedRouteITest {
+
+ private static final String TEXT_SAMPLE = "The quick brown fox jumps over
the lazy dog";
+
+ @Override
+ public String getBodyToSend() {
+ return TEXT_SAMPLE;
+ }
+
+ @Override
+ public void configureMock(MockEndpoint mock) {
+ // The feature resolves and the route processes exactly one exchange
without error.
+ mock.expectedMessageCount(1);
+ }
+
+ @Test
+ public void testResultMock() throws Exception {
+ assertMockEndpointsSatisfied();
+ }
+}
diff --git a/tests/features/pom.xml b/tests/features/pom.xml
index eb6100515..a931eb2ea 100644
--- a/tests/features/pom.xml
+++ b/tests/features/pom.xml
@@ -110,6 +110,7 @@
<module>camel-quartz</module>
<module>camel-saxon</module>
<module>camel-spring-rabbitmq</module>
+ <module>camel-tika</module>
<module>camel-velocity</module>
<module>camel-weather</module>
<module>camel-xslt-saxon</module>
