jbonofre commented on code in PR #737:
URL: https://github.com/apache/camel-karaf/pull/737#discussion_r3864393933
##########
features/src/main/feature/camel-features.xml:
##########
@@ -315,9 +315,27 @@
<condition>shell</condition>
<bundle>mvn:org.apache.camel.karaf/camel-karaf-shell/${project.version}</bundle>
</conditional>
- <!-- allow camel to access its own mbeans for karaf commands and other
needs -->
+ <!--
+ JMX role mapping for the org.apache.camel MBean domain.
+
+ Karaf resolves ACL PIDs most specific first and only falls through
to the
+ next one when no rule in the current PID matches the operation, so
this
+ file needs to list only the operations that should differ from the
stock
+ jmx.acl defaults (get*/list*/is* = viewer, everything else =
admin).
+
+ Context and route lifecycle is mapped to manager, matching how
Karaf maps
+ bundle lifecycle in its own jmx.acl.org.apache.karaf.bundle.
Everything not
+ listed here - message injection (sendBody*, requestBody*),
endpoint and
+ route mutation (createEndpoint, removeEndpoints,
addOrUpdateRoutes*) and
+ the dump* operations, which resolve property placeholders - falls
through
+ to the jmx.acl default of admin.
+ -->
<config name="jmx.acl.org.apache.camel">
- * = *
+ start* = manager
+ stop* = manager
+ suspend* = manager
+ resume* = manager
+ reset* = manager
Review Comment:
That makes sense. However, I think it's a breaking change because,
previously, `* = *` means that everything was `viewer` by default.
So, your change makes sense, but we need to re-add the viewer stuff.
We should probably add:
```suggestion
reset* = manager
dump* = viewer
browse* = viewer
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
