atiaomar1978-hub commented on PR #25507: URL: https://github.com/apache/camel/pull/25507#issuecomment-5433583857
## All @gnodet review items addressed **Commit:** \`0564fbfdbbc\` — _CAMEL-23861: Address all gnodet review feedback on GenAI observability_ ### #1 Orphan service file (previously fixed) Removed dead \`org.apache.camel.main.AiConfigurationProperties\` META-INF descriptor in \`dc007256883\`. ### #2 Fragile private-field reflection - Documented the \`chatClient\`-only limitation in \`ai-observability.adoc\` and \`spring-ai-chat-component.adoc\` - Added a one-time startup **WARN** when GenAI observability is enabled but \`ChatModel\` cannot be resolved from \`ChatClient\`, recommending explicit \`chatModel\` configuration - Clarified in javadoc that \`extractChatModelFromClient\` relies on Spring AI internal API ### #3 Static METHOD_CACHE classloader concern - Cache keys now use declaring **class name** strings instead of \`Class<?>\` references - Cached \`Method\` instances stored as \`SoftReference\` values so entries can be reclaimed under memory pressure / classloader recycling - Re-validates \`Method.getDeclaringClass()\` on cache hit for classloader reload safety ### #4 String matching in mapLangChain4jProvider - Added named \`LC4J_PROVIDER_*\` constants aligned with LangChain4j \`ModelProvider\` enum names - Added tests for Anthropic mapping and unrecognized provider → \`unknown\` ### Tests (local) \`\`\`bash ./mvnw -pl components/camel-ai/camel-ai-observability,components/camel-ai/camel-ai-observability-api,components/camel-spring-parent/camel-spring-ai/camel-spring-ai-chat -am test -Dtest=GenAiModelResolverTest,SpringAiChatObservabilityTest \`\`\` **Result:** green --- _Composer on behalf of atiaomar1978-hub (AI-generated)_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
