atiaomar1978-hub commented on PR #25558: URL: https://github.com/apache/camel/pull/25558#issuecomment-5433658648
## @gnodet review feedback addressed **Commit:** \`52a43699f70\` — _CAMEL-24408: Address gnodet review on SEDA queue lifecycle_ ### Changes 1. **\`hasProducers()\` usage** — \`onShutdownEndpoint()\` now checks \`ref.hasConsumers()\` and \`ref.hasProducers()\` before removing the shared queue from the component map (cross-endpoint semantics). 2. **Redundant \`getOrCreateQueue()\`** — \`onStarted(SedaProducer)\` now re-registers the queue only when \`ref == null || queue == null\` (producer restart after queue release), not on every producer start. 3. **Double \`onShutdownEndpoint\` invocation** — Added comments documenting that \`onStopped\` and \`shutdown()\` may both call it; the method is idempotent. 4. **Grammar** — Fixed debug messages to \"There **are** still active consumers or producers.\" in \`stop()\` and \`shutdown()\`. ### Tests (local) \`\`\`bash ./mvnw -pl core/camel-core -am -Dtest=SedaDiscardIfNoConsumerAfterRemovalTest,SedaDiscardIfNoConsumersProducerRouteRestartTest,SedaDiscardIfNoConsumerTest test \`\`\` **Result:** green --- _Composer on behalf of atiaomar1978-hub (AI-generated)_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
