davsclaus commented on code in PR #25876:
URL: https://github.com/apache/camel/pull/25876#discussion_r3882062864
##########
components/camel-salesforce/camel-salesforce-maven-plugin/src/main/java/org/apache/camel/maven/AbstractSalesforceMojo.java:
##########
@@ -243,6 +244,15 @@ private void validateAuthenticationParameters() throws
MojoExecutionException {
"Property 'keystorePassword' must be provided when
property 'keystoreResource' was provided."); // NOSONAR
}
}
+
+ if (authenticationType == null && clientSecret != null && userName !=
null && password == null
Review Comment:
This is the headline new safety behavior described in the PR body, but it
has no fast/unit test covering it. The three new tests in
`CamelSalesforceLoginManualIT` need live Salesforce credentials and are
excluded from normal `mvn test`/CI runs by the `ManualIT` naming convention, so
they give no regression protection here.
`validateAuthenticationParameters()` runs before
`setup()`/`execution.execute()` (see `execute()` above), so a plain JUnit test
could construct a Mojo subclass, set `clientId`/`clientSecret`/`userName` with
`password == null` and `keystoreResource == null`, call `execute()`, and assert
a `MojoExecutionException` is thrown with this message — no network access
needed. Worth adding, per the project's "every PR must include tests for new
functionality or bug fixes" rule.
##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_23.adoc:
##########
@@ -459,6 +459,16 @@ Ordinary listings are unaffected, as a listed name is
normally a single path seg
resolves back inside the polled directory remains accepted. Two configurations
can newly see files skipped: a
server that reports names navigating above the polled directory, and a
`fileName` expression (used when
`useList=false`) that navigates above it. Set `jailStartingDirectory=false` if
such a path is intended.
+=== camel-salesforce
Review Comment:
Missing the blank line before the new heading that every other section
boundary in this file has.
```suggestion
`useList=false`) that navigates above it. Set `jailStartingDirectory=false`
if such a path is intended.
=== camel-salesforce
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
