mayurbm commented on PR #25907: URL: https://github.com/apache/camel/pull/25907#issuecomment-5476550184
@davsclaus @gnodet Thank you both for the thorough re-reviews. All feedback addressed: **Per gnodet:** 1. **Removed dead-code ternary** — `currentFolder` is guaranteed non-null (assigned after the `if (folder == null) throw ISE` guard), so simplified to `currentFolder.getName()` directly ✅ 2. **Removed GreenMail dependency from test** — replaced `Mailbox.getSessionProperties(Protocol.imap)` + `Mailbox.getPort(Protocol.imap)` with `Session.getInstance(new Properties())` and port `3143` ✅ 3. **Extracted reflection field names into constants** — `FIELD_FOLDER = "folder"` and `FIELD_STORE = "store"` ✅ **Per davsclaus:** - JIRA CAMEL-24567 is now **assigned to the contributor** ✅ - Noted the follow-up scope (`retrieveMessages()` / `retrieveAllMessages()` still read `folder` directly) — will create a follow-up ticket Local `camel-mail` full test suite passes with JDK 21. _Claude Code on behalf of mayurbm_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
