oscerd commented on PR #25939:
URL: https://github.com/apache/camel/pull/25939#issuecomment-5478535253
Thanks for checking the test actually fails without the fix — that is the
part I would have wanted verified too.
Taken: the `developerPrompt` branch now reads
```java
if ((developerPrompt == null || developerPrompt.isEmpty())
&& ObjectHelper.isNotEmpty(config.getDeveloperMessage())) {
developerPrompt = config.getDeveloperMessage();
}
```
You are right that it is harmless today, for the same reason `systemPrompt`
was: the downstream `ObjectHelper.isNotEmpty(developerPrompt)` guard drops a
null before the message is added. Leaving one of three identical instances
behind was an oversight rather than a decision, so it belongs in this pass.
Built the module and ran the OpenAI tests, plus a full reactor build from
the root, both clean. The three catalog doc files that the CI bot flagged as
uncommitted are the `structured_error_exchange_properties` anchor drift on
`main`, which `b46db0bad3f1` (#25941) regenerated at 10:25 today — after that
CI run — so a re-run should be clean.
_Claude Code on behalf of oscerd_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
