oscerd commented on PR #2997: URL: https://github.com/apache/camel-kamelets/pull/2997#issuecomment-5491664181
Pushed a fix for the red `build` check. `KameletsCatalogTest.testGetKameletsByNamespace` asserts an **exact** count for the AWS namespace, so a new AWS Kamelet fails it by construction: ``` KameletsCatalogTest.testGetKameletsByNamespace:124 expected: <31> but was: <32> ``` Bumped the expectation to 32. Verified against the tree rather than just trusting the CI delta — 31 Kamelets carry `kamelet.namespace: "AWS"` on `main`, 32 with this branch. Worth noting the AWS namespace is the only one with a count assertion, which is why the SMPP and SNMP Kamelets in #2988, #2989 and #2990 did not trip it. If a maintainer would rather this were a lower bound than a change detector, that is a reasonable separate cleanup — but changing the assertion's intent felt like scope creep inside a Kamelet PR, so I left the design alone and just updated the number. My own fault for not catching it before opening: I had run the root build with `-DskipTests`, which skips the catalog module's tests entirely. Re-ran the full `mvn clean install` with tests after the fix: ``` Tests run: 18, Failures: 0, Errors: 0, Skipped: 0 -- in KameletsCatalogTest BUILD SUCCESS ``` Also rebased onto current `main` while I was here, so the branch is up to date. --- _Claude Code on behalf of Andrea Cosentino_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
