davsclaus commented on code in PR #1729:
URL: https://github.com/apache/camel-website/pull/1729#discussion_r3906863463
##########
antora-ui-camel/src/js/08-docsearch.js:
##########
@@ -0,0 +1,128 @@
+;(function () {
+ 'use strict'
+
+ // The index has no attributeForDistinct and no attributesForFaceting, so
both the sub-project
+ // exclusion and the per-page dedupe below have to run client side. Fetch
deeper than the
+ // DocSearch default of 20 so filtering does not starve the result list: at
20 a query like
+ // "timer" is left with hits from a single page. Measured against the live
index, 75 lifts
+ // "timer" from 5 to 8 distinct pages and "aggregate" from 9 to 13; 100 adds
almost nothing
+ // beyond that but doubles the response to ~36 KB gzipped.
+ var HITS_PER_PAGE = 75
Review Comment:
The PR description's table says `hitsPerPage: 50`, but this sets
`HITS_PER_PAGE = 75`. Not a bug — just stale prose in the description worth a
quick correction. Also worth noting: the new test only asserts `>= 50`, so it
wouldn't catch a future regression back down to 50.
##########
antora-ui-camel/src/css/pagination.css:
##########
@@ -1,31 +1,40 @@
nav.pagination {
display: flex;
- border-top: 1px solid var(--toolbar-border-color);
+ gap: 1rem;
line-height: 1;
- margin: 2rem -1rem -1rem;
- padding: 0.75rem 1rem 0;
+ margin: 2rem 0 0;
}
+/* NOTE align-items keeps the anchor at its text width. .doc a draws its
underline with a
+ repeating background-image gradient, so a stretched anchor paints that
dashed line across the
+ whole half-width of the box instead of just under the label. */
nav.pagination span {
display: flex;
- flex: 50%;
+ flex: 0 1 calc(50% - 0.5rem);
flex-direction: column;
+ gap: 0.4rem;
Review Comment:
The PR description frames this file's change as a one-line `align-items` fix
for the underline-stretching bug, but this hunk also adds `gap`, `border`,
`border-radius`, and a hover accent, and removes the old top separator. The
underline fix itself (`align-items` on `.prev`/`.next`) is correct — just
flagging that a small visual redesign is bundled in beyond what the description
calls out.
##########
tools/asciinema/.camel-jbang/camel-jbang-run.properties:
##########
@@ -0,0 +1,26 @@
+loggingLevel=info
Review Comment:
This looks like a JBang-generated local run-config dotfile (auto-created
under `.camel-jbang/` when running `camel-jbang`). No secrets and nothing
machine-specific, but worth confirming this is meant to be a committed fixture
for reproducing the demo recording rather than an accidental local artifact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
