atiaomar1978-hub commented on PR #26027:
URL: https://github.com/apache/camel/pull/26027#issuecomment-5502795378
## Review follow-up (Bugbot + security review)
_AI-generated comment on behalf of atiaomar1978-hub_
### Findings addressed in latest commits
1. **Catalog mirror out of sync (Bugbot, medium)** — Regenerated
`catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/docs/langchain4j-agent-component.adoc`
via `mvn -pl catalog/camel-catalog clean generate-resources` so the new
Tool-calling options / `withAiServicesCustomizer` documentation is mirrored for
CI.
2. **Brittle assertion (security review, low)** —
`maxToolCallingRoundTripsIsEnforced` now asserts exception type + partial
message (`tool calling round trips`) instead of an exact LangChain4j error
string.
### Review notes (no code change required)
- **Security**: Customizer hook is route-author configuration only
(registry/bean), not URI-exposed — no new untrusted trust-boundary path.
- **Test flakiness**: Tests use deterministic stub `ChatModel`s; no
`Thread.sleep()` or timing dependencies.
- **Scope**: Core CAMEL-23928 API landed in #24492; this PR adds behavioral
coverage + docs to close the ticket.
### Tests run locally
```bash
mvn test -pl
components/camel-ai/camel-langchain4j-agent-api,components/camel-ai/camel-langchain4j-agent
-am \
-Dtest=AgentConfigurationToolCallingBehaviorTest,LangChain4jAgentAiServicesCustomizerTest
\
-DfailIfNoTests=false -Ddevelocity.buildCache.local.enabled=false
```
All 6 new tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
